Handling of ellipsis in traceback comparisons for doctests #13039
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @shannoncai! Please take a look at the comments.
| got = self._remove_unwanted_precision(want, got) | ||
|
|
||
| if "..." in want: | ||
| want_regex = re.escape(want).replace(r"\.\.\.", ".*") |
There was a problem hiding this comment.
This is a bit simplistic in the sense that it will replace any ... found in the docstring, even if they are used in places where we don't want this replacement to happen, say inside a string literal.
Perhaps we can limit our replacement to lines containing a single ... (minus spaces)?
Here is how the stdlib does this: https://github.com/python/cpython/blob/1503fc8f88d4903e61f76a78a30bcd581b0ee0cd/Lib/doctest.py#L295-L342
I'm OK with copying that code over pytest.
| print(f"Transformed WANT: {want_regex}") # Debugging output | ||
| print(f"GOT: {got}") # Debugging output |
There was a problem hiding this comment.
Seems like those are left-overs.
| print(f"Transformed WANT: {want_regex}") # Debugging output | |
| print(f"GOT: {got}") # Debugging output |
| assert _is_main_py(dunder_main) == expected | ||
|
|
||
|
|
||
| def test_doctest_wildcard(pytester): |
There was a problem hiding this comment.
| def test_doctest_wildcard(pytester): | |
| def test_doctest_wildcard(pytester: Pytester) -> None: |
| # Create a Python file with a function that raises a ValueError and includes a doctest. | ||
| pytester.makepyfile( | ||
| """ | ||
| def _test_doctest_wildcard(): |
There was a problem hiding this comment.
| def _test_doctest_wildcard(): | |
| def doctest_wildcard(): |
| @@ -0,0 +1 @@ | |||
| Fix handling of ellipsis (...) in traceback comparisons for doctests | |||
There was a problem hiding this comment.
| Fix handling of ellipsis (...) in traceback comparisons for doctests | |
| Fix handling of ellipsis (``...``) in traceback comparisons for doctests. |
|
Closing as this has not seen activity in awhile. Feel free to reopen if you want to work on this again. |
2 participants
Handles #12417